Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Avoid rich 10.15.0 and 10.15.1 #12293

Merged
merged 5 commits into from
Mar 18, 2022
Merged

Avoid rich 10.15.0 and 10.15.1 #12293

merged 5 commits into from
Mar 18, 2022

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Mar 10, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #11034.

Avoids these two versions which seem to cause deadlock as reported in Textualize/rich#1734.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @SeanNaren @kaushikb11

@akihironitta akihironitta added this to the 1.6 milestone Mar 10, 2022
kaushikb11
kaushikb11 reviewed Mar 11, 2022
View reviewed changes
@akihironitta @kaushikb11
Update requirements/extra.txt
7b9966c 
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
@akihironitta akihironitta requested a review from kaushikb11 March 11, 2022 14:43
@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2022
krshrimali
krshrimali approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krshrimali krshrimali enabled auto-merge (squash) March 15, 2022 08:34
@krshrimali krshrimali merged commit 09d1296 into master Mar 18, 2022
@krshrimali krshrimali deleted the bugfix/rich-deadlock branch March 18, 2022 19:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@krshrimali krshrimali krshrimali approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

Assignees
No one assigned
Labels
progress bar: rich ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.

RichProgressBar deadlocking during non-distributed training
7 participants
@akihironitta @ananthsub @awaelchli @Borda @carmocca @krshrimali @kaushikb11